Re: [Qemu-devel] [PATCH] tests/tcg/multiarch: fix 32bit linux-test on 64bit host

[Laurent Vivier]

On 14/11/2018 11:23, Alex Bennée wrote:
> 
> Laurent Vivier <address@hidden> writes:
> 
>> Fix:
>>
>>   TEST    linux-test on i386
>>   .../tests/tcg/multiarch/linux-test.c:201: readdir
>>
>> readdir() calls getdents64() to have the list of the entries in a
>> directory, and getdents64() can return 64bit d_off values (with ext4,
>> for instance) that will not fit in the 32bit d_off field of the
>> readdir() dirent structure.
>>
>> To avoid that, use readdir64() to use a 64bit d_off field too.
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
> 
> I guess the only remaining question is do we want to defend the other
> case or just say it's not supported and all binaries are expected to use
> modern-ish libcs with getdents64?

IMO, linux-test is only a smoke test to check basic behaviour of qemu
usermode. So it's not really important on what readdir() relies on.

On my side, I generally run full LTP test on x86_64 and ppc64 hosts with
several debian distros and ubuntu guests, so the other cases should be
tested at one point.

> Anyway:
> 
> Reviewed-by: Alex Bennée <address@hidden>
> 
> I'm preparing a pull-req with a travis patch, would you like me to
> include this as well?

Yes, please.

Thanks,
Laurent