[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] intel-iommu: extend iotlb search logic t
|
From: |
Yu Zhang |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] intel-iommu: extend iotlb search logic to cover 57-bit IOVA. |
|
Date: |
Wed, 14 Nov 2018 14:48:33 +0800 |
|
User-agent: |
NeoMutt/20180622-66-b94505 |
On Wed, Nov 14, 2018 at 02:41:15PM +0800, Peter Xu wrote:
> On Wed, Nov 14, 2018 at 02:04:44PM +0800, Yu Zhang wrote:
> > The 64-bit key used by vtd_lookup_iotlb() to search the cached
> > mappings is formed by combining the GFN, source id and the page
> > level. To cover 57-bit IOVA, the shift of source id and of page
> > level need to be enlarged by 9 - the stride of one paging structure
> > level.
> >
> > Signed-off-by: Yu Zhang <address@hidden>
>
> Reviewed-by: Peter Xu <address@hidden>
>
> But note that we should have this patch either squashed into previous
> patch, or at least it should appear earlier than patch 2 since
> otherwise patch 2 could possibly break. I would prefer squashing
> since it's really part of patch 2, and please feel free to pick my r-b
> if you want to resent with a squashed version in the future.
>
Got it. Thanks, Peter. Will send the squashed patch right after the release. :)
> Regards,
>
> --
> Peter Xu
B.R.
Yu