Re: [Qemu-devel] [RFC PATCH 07/11] scripts/decodetree: Add add_func_check()

[Richard Henderson]

On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote:
>          for n, f in self.fields.items():
>              output(ind, 'u.f_', arg, '.', n, ' = ', f.str_extract(), ';\n')
> +        for f, a in self.check_funcs:
> +            output(ind, 'check_', f, '(ctx, ', a, ');\n')
>          output(ind, 'return ', translate_prefix, '_', self.name,
>                 '(ctx, &u.f_', arg, ');\n')

I don't see the value in asserting the isa here.
If this were a conditional check, which might fall through to either another
pattern or to return false, maybe.


r~