Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

[Peter Maydell]

On 9 November 2018 at 14:14, Gerd Hoffmann <address@hidden> wrote:
> Broken (segfaultson first keypress) and appearently unused.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  include/hw/bt.h     |   3 -
>  hw/bt/hid.c         | 554 
> ----------------------------------------------------
>  vl.c                |  34 +---
>  hw/bt/Makefile.objs |   3 +-
>  qemu-options.hx     |   9 -
>  5 files changed, 2 insertions(+), 601 deletions(-)
>  delete mode 100644 hw/bt/hid.c

Are we definitely happy that all the use cases for
this code segfault, not just the one you tested ?
Does it cost us much to mark this deprecated in 3.1
and drop it in 4.0 ?

thanks
-- PMM