[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of s
From: |
Maciej W. Rozycki |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes |
Date: |
Fri, 9 Nov 2018 16:49:29 +0000 (GMT) |
User-agent: |
Alpine 2.21 (LFD 202 2017-01-01) |
On Fri, 9 Nov 2018, Aleksandar Markovic wrote:
> > > I think that the best solution that you exclude DDIV, DDIVU, DMULT, DMULTU
> > > in a separate patch - there is no document to support their inclusion.
> >
> > As Maciej noted, the 64-bit MIPS Linux psABI is indivisible, so how could
> > your alternative possibly work?
>
> Since we are rapidly approaching 3.1 release, we don't have time for
> prolonged discussions - so please provide the patch that removes
> emulation of these instructions that don't belong to R5900 set, and, if
> you find a justification document later on, they can be reintroduced in
> 3.1+ timeframe.
You know well enough that nobody was bothered over the years to actually
document the 64-bit MIPS Linux psABI (there is the 64-bit ELF document
from SGI, relevant for IRIX, which has been partially implemented by
Linux) and even when it comes to the 32-bit psABI the only document is
from SGI from mid 1990s, that has several errors and surely was not
written with Linux in mind (and FWIW not entirely with IRIX either).
The psABI has been set by the architecture back in 1991 and what Linux
has implemented on top of that around 2001, along with common sense. You
can't question what was done 17 years ago asking for a backing piece of
paper (possibly virtual). You can put anything on paper and if it does
not match reality, then it is irrelevant.
If you question what I state, then ask the MIPS/Linux kernel developers
at the relevant mailing list, i.e. <address@hidden>.
Maciej
- [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, (continued)
- [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Fredrik Noring, 2018/11/07
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Aleksandar Markovic, 2018/11/08
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Aleksandar Markovic, 2018/11/09
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Fredrik Noring, 2018/11/09
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Aleksandar Markovic, 2018/11/09
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Fredrik Noring, 2018/11/09
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Aleksandar Markovic, 2018/11/09
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Aleksandar Markovic, 2018/11/09
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes,
Maciej W. Rozycki <=
- Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Maciej W. Rozycki, 2018/11/09
Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes, Aleksandar Markovic, 2018/11/17
[Qemu-devel] [PATCH v2 5/6] target/mips: Guard check_insn_opc_user_only with INSN_R5900 check, Fredrik Noring, 2018/11/07
[Qemu-devel] [PATCH v2 6/6] target/mips: Guard check_insn with INSN_R5900 check, Fredrik Noring, 2018/11/07