[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1] replay: Exit on errors reading from rep
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH for-3.1] replay: Exit on errors reading from replay log |
|
Date: |
Thu, 8 Nov 2018 14:42:18 +0000 |
On 6 November 2018 at 22:19, Paolo Bonzini <address@hidden> wrote:
> On 06/11/2018 16:33, Peter Maydell wrote:
>> Currently replay_get_byte() does not check for an error
>> from getc(). Coverity points out (CID 1390622) that this
>> could result in unexpected behaviour (such as looping
>> forever, if we use the replay_get_dword() return value
>> for a loop count). We don't expect reads from the replay
>> log to fail, and if they do there is no way we can
>> continue. So make them fatal errors.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
> Makes sense, can you apply it directly to qemu.git as soon as Pavel
> reviews it (or in some time if he doesn't)?
Applied to master, thanks.
-- PMM