qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] List of files containing devices which have not been QO


From: Palmer Dabbelt
Subject: Re: [Qemu-devel] List of files containing devices which have not been QOMified
Date: Wed, 07 Nov 2018 10:53:02 -0800 (PST)

On Tue, 06 Nov 2018 10:43:17 PST (-0800), Peter Maydell wrote:
I had an idea for how to get a rough list of source files
containing devices that haven't been QOMified. The theory
is that a pre-QOM device generally has an "init" function
which allocates memory for the device struct. So looking in
hw/ for files which call g_new*() or g_malloc*() should get
us all the non-QOM devices (as well as a pile of false
positives, of course). The following link is the result of
doing that and then eyeballing the results for false positives
and throwing those out. It might have missed one or two
files or included one or two by mistake. But I think it's
pretty close, and it seems to have caught all the obvious
ones I knew about. There are 61 files on this list.

I am also suspicious about hw/bt/ but don't know enough
about that subsystem to say if it could benefit from
using QOM objects more.

[...]

hw/riscv/riscv_htif.c
hw/riscv/sifive_uart.c

I poked around at it looks like both of these are valid targets for a QOM conversion, and I think the UART in particular would be meaningfully more useful with a conversion. I'll add it to my TODO list, but I'm not sure how long it'll take to get around to it -- sorry!

Thanks for pointing this out!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]