[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ t
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/ |
Date: |
Tue, 6 Nov 2018 17:16:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote:
> On 6/11/18 15:13, Michael S. Tsirkin wrote:
>> On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
>>> On 5/11/18 19:14, Michael S. Tsirkin wrote:
>>>> From: Peter Maydell <address@hidden>
>>>>
>>>> Currently tests/hex-loader-check-data contains data files used
>>>> by the hexloader-test, and configure individually symlinks those
>>>> data files into the build directory using a wildcard.
>>>>
>>>> Using a wildcard like this is a bad idea, because if a new
>>>> data file is added, nothing causes configure to be rerun,
>>>> and so no symlink is added for the new file. This can cause
>>>> tests to spuriously fail when they can't find their data.
>>>> Instead, it's better to symlink an entire directory of
>>>> data files. We already have such a directory: tests/data.
>>>>
>>>> Move the data files from tests/hex-loader-check-data/ to
>>>> tests/data/hex-loader/, and remove the unnecessary symlinking.
>>>>
>>>> Signed-off-by: Peter Maydell <address@hidden>
>>>
>>> I reviewed/tested this patch too.
>>
>>
>> Thanks a lot Philippe!
>> It is unfortunately too late to update this patch info in git
>> commit history, however your help is still greatly appreciated!
>
> No worry, I'm not mad at all, but there might be an issue in your git PR
> workflow, this series also missed your maintainer S-o-b.
>
> Peter: Can you add a such check in your scripts? (during next merge
> window, no hurry).
>
> Rather than your scripts, this should be in scripts a maintainer can run
> locally, such ./scripts/checkpatch.pl --maintainer or
> ./scripts/checkseries.xx.
I think such tool already exists: with git-publish you can configure a
"pre-publish-send-email" hook, and check your S-o-B is present.
Thanks,
Laurent
- [Qemu-devel] [PULL 00/33] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, Michael S. Tsirkin, 2018/11/05
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, Philippe Mathieu-Daudé, 2018/11/06
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, Michael S. Tsirkin, 2018/11/06
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/,
Laurent Vivier <=
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, Stefan Hajnoczi, 2018/11/08
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, Laurent Vivier, 2018/11/08
- Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/, Philippe Mathieu-Daudé, 2018/11/08
[Qemu-devel] [PULL 01/33] tests: Move tests/acpi-test-data/ to tests/data/acpi/, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 03/33] configure: Rename FILES variable to LINKS, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 04/33] configure: Use LINKS loop for all build tree symlinks, Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 06/33] intel_iommu: introduce vtd_reset_caches(), Michael S. Tsirkin, 2018/11/05
[Qemu-devel] [PULL 05/33] virtio-blk: fix comment for virtio_blk_rw_complete, Michael S. Tsirkin, 2018/11/05