[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: tpm: Use g_test_message rather than fpri
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] tests: tpm: Use g_test_message rather than fprintf |
Date: |
Tue, 6 Nov 2018 16:21:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-06 16:13, Stefan Berger wrote:
> Display a message during the test using g_test_message rather
> than fprintf.
>
> Signed-off-by: Stefan Berger <address@hidden>
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 93a5beba01..5f217a2d92 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
> tpm_test_swtpm_skip(void)
> {
> if (!tpm_util_swtpm_has_tpm2()) {
> - fprintf(stderr, "swtpm not in PATH or missing --tpm2 support; ");
> + g_test_message("swtpm not in PATH or missing --tpm2 support; ");
> return true;
> }
I think I'd rather remove the semicolon at the end now. Anyway:
Reviewed-by: Thomas Huth <address@hidden>