qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v7 7/9] migration: remove unused &local_err


From: Fei Li
Subject: Re: [Qemu-devel] [PATCH RFC v7 7/9] migration: remove unused &local_err parameter in migrate_set_error
Date: Tue, 6 Nov 2018 12:51:54 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1



On 11/05/2018 09:59 PM, Juan Quintela wrote:
Fei Li <address@hidden> wrote:
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Error is not used, you are right.

But then just change the prototype to:

void multifd_save_cleanup(void);

??

With that change,

Reviewed-by: Juan Quintela <address@hidden>
Thanks for the review!
Have changed that function to be void, besides, correct the previous erroneous
function name in the patch title:
s/migratr_set_error/multifd_save_cleanup/g.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]