[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 3/5] qemu-img: assert block_job_get() does not re
From: |
Liam Merwick |
Subject: |
[Qemu-devel] [PATCH v5 3/5] qemu-img: assert block_job_get() does not return NULL in img_commit() |
Date: |
Mon, 5 Nov 2018 21:38:37 +0000 |
Although the function block_job_get() can return NULL, it would be a
serious bug if it did so (because the job yields before executing anything
(if it started successfully); but otherwise, commit_active_start() would
have returned an error). However, as a precaution, before dereferencing
the 'job' pointer in img_commit() assert it is not NULL.
Signed-off-by: Liam Merwick <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index b12f4cd19b0a..457aa152296b 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1029,6 +1029,7 @@ static int img_commit(int argc, char **argv)
}
job = block_job_get("commit");
+ assert(job);
run_block_job(job, &local_err);
if (local_err) {
goto unref_backing;
--
1.8.3.1
- [Qemu-devel] [PATCH v5 0/5] off-by-one and NULL pointer accesses detected by static analysis, Liam Merwick, 2018/11/05
- [Qemu-devel] [PATCH v5 5/5] qcow2: Read outside array bounds in qcow2_pre_write_overlap_check(), Liam Merwick, 2018/11/05
- [Qemu-devel] [PATCH v5 1/5] job: Fix off-by-one assert checks for JobSTT and JobVerbTable, Liam Merwick, 2018/11/05
- [Qemu-devel] [PATCH v5 3/5] qemu-img: assert block_job_get() does not return NULL in img_commit(),
Liam Merwick <=
- [Qemu-devel] [PATCH v5 4/5] block: Fix potential Null pointer dereferences in vvfat.c, Liam Merwick, 2018/11/05
- [Qemu-devel] [PATCH v5 2/5] block: Null pointer dereference in blk_root_get_parent_desc(), Liam Merwick, 2018/11/05
- Re: [Qemu-devel] [PATCH v5 0/5] off-by-one and NULL pointer accesses detected by static analysis, Max Reitz, 2018/11/11