[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 30/33] i440fx: use ARRAY_SIZE for pam_regions
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 30/33] i440fx: use ARRAY_SIZE for pam_regions |
Date: |
Mon, 5 Nov 2018 13:17:07 -0500 |
From: Li Qiang <address@hidden>
Cc: address@hidden
Signed-off-by: Li Qiang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci-host/piix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index ec5441583a..b5ded1a806 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -142,7 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
PCIDevice *pd = PCI_DEVICE(d);
memory_region_transaction_begin();
- for (i = 0; i < 13; i++) {
+ for (i = 0; i < ARRAY_SIZE(d->pam_regions); i++) {
pam_update(&d->pam_regions[i], i,
pd->config[I440FX_PAM + DIV_ROUND_UP(i, 2)]);
}
@@ -412,7 +412,7 @@ PCIBus *i440fx_init(const char *host_type, const char
*pci_type,
init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
&f->pam_regions[0], PAM_BIOS_BASE, PAM_BIOS_SIZE);
- for (i = 0; i < 12; ++i) {
+ for (i = 0; i < ARRAY_SIZE(f->pam_regions) - 1; ++i) {
init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
&f->pam_regions[i+1], PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE,
PAM_EXPAN_SIZE);
--
MST
- [Qemu-devel] [PULL 17/33] i386: acpi: add IVHD device entry for IOAPIC, (continued)
- [Qemu-devel] [PULL 17/33] i386: acpi: add IVHD device entry for IOAPIC, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 12/33] x86_iommu: move vtd_generate_msi_message in common file, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 15/33] x86_iommu/amd: Prepare for interrupt remap support, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 24/33] bios-tables-test: prepare expected files for mmio64, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 26/33] hw/pci-bridge/xio3130: Remove unused functions, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 25/33] tests/bios-tables-test: add 64-bit PCI MMIO aperture round-up test on Q35, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 28/33] hw/pci: Add missing include, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 22/33] hw/pci-host/x86: extract get_pci_hole64_start_value() helpers, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 27/33] hw/pci-bridge/ioh3420: Remove unuseful header, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 29/33] pci_bridge: fix typo in comment, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 30/33] i440fx: use ARRAY_SIZE for pam_regions,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 31/33] piix: use TYPE_FOO constants than string constats, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 32/33] piix_pci: fix i440fx data sheet link, Michael S. Tsirkin, 2018/11/05
- [Qemu-devel] [PULL 33/33] vhost-scsi: prevent using uninitialized vqs, Michael S. Tsirkin, 2018/11/05
- Re: [Qemu-devel] [PULL 00/33] pci, pc, virtio: fixes, features, Thomas Huth, 2018/11/06
- Re: [Qemu-devel] [PULL 00/33] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2018/11/06
- Re: [Qemu-devel] [PULL 00/33] pci, pc, virtio: fixes, features, Peter Maydell, 2018/11/06
- Re: [Qemu-devel] [PULL 00/33] pci, pc, virtio: fixes, features, Peter Maydell, 2018/11/06
- Re: [Qemu-devel] [PULL 00/33] pci, pc, virtio: fixes, features, Laszlo Ersek, 2018/11/06