[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication |
Date: |
Mon, 5 Nov 2018 11:02:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-01 03:12, Zhang Chen wrote:
> This compilation issue will occur when user use --disable-replication
> to config Qemu.
>
> Reported-by: Thomas Huth <address@hidden>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
> migration/colo.c | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
Thanks, this fixes the compilation problem with --disable-replication
for me:
Tested-by: Thomas Huth <address@hidden>
BTW, if colo can't be used without CONFIG_REPLICATION, would it make
sense to disable the related objects (for the "--object" parameter) in
an additional patch, too? Something like this (untested):
diff --git a/net/Makefile.objs b/net/Makefile.objs
--- a/net/Makefile.objs
+++ b/net/Makefile.objs
@@ -10,7 +10,7 @@ common-obj-$(CONFIG_NETMAP) += netmap.o
common-obj-y += filter.o
common-obj-y += filter-buffer.o
common-obj-y += filter-mirror.o
-common-obj-y += colo-compare.o
+common-obj-$(CONFIG_REPLICATION) += colo-compare.o
common-obj-y += colo.o
common-obj-y += filter-rewriter.o
common-obj-y += filter-replay.o
Thomas
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Peter Xu, 2018/11/14
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Thomas Huth, 2018/11/14
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Peter Maydell, 2018/11/14
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Zhang Chen, 2018/11/14
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Peter Xu, 2018/11/14
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Dr. David Alan Gilbert, 2018/11/16
- Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Zhang Chen, 2018/11/17
Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication, Dr. David Alan Gilbert, 2018/11/21