Re: [Qemu-devel] [PATCH] docker: Use a stable snapshot for Debian Sid

[Philippe Mathieu-Daudé]

Hi Fam,

Thanks for picking this.

On Fri, Nov 2, 2018 at 7:48 AM Fam Zheng <address@hidden> wrote:
> On Thu, 11/01 19:37, Philippe Mathieu-Daudé wrote:
> > The Debian Sid repository is not garanteed to be stable, as his
> > 'unstable' name suggest :)

There is an error in "my be" -> "might be"...
Do you mind to update the comment:

> > To allow quick testing, packages are pushed various time a day,
> > which my be annoying when trying to use it for stable development
> > (which is not recommended, but Sid provides edge packages we use
> > for testing).

By:

To allow quick testing, Debian maintainers might push packages
various time a day. Sometime package dependencies might break,
which is annoying when using this repository for stable development
(which is not recommended, but Sid provides edge packages we use
for testing).

I can resend as v2 if you prefer.

Thanks!

Phil.

> > (which is not recommended, but Sid provides edge packages we use
> > for testing).
> >
> > Debian provides repositories snapshots which are suitable for our
> > use. Pick a recent date that works. When required, update to newer
> > releases will be easy.
> >
> > This fixes current issues with this image:
> >
> >   $ make docker-image-debian-sid
> >   [...]
> >   The following packages have unmet dependencies:
> >    build-essential : Depends: dpkg-dev (>= 1.17.11) but it is not going to 
> > be installed
> >    git : Depends: perl but it is not going to be installed
> >          Depends: liberror-perl but it is not going to be installed
> >    pkg-config : Depends: libdpkg-perl but it is not going to be installed
> >    texinfo : Depends: perl (>= 5.26.2-6) but it is not going to be installed
> >              Depends: libtext-unidecode-perl but it is not going to be 
> > installed
> >              Depends: libxml-libxml-perl but it is not going to be installed
> >   E: Unable to correct problems, you have held broken packages.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >  tests/docker/dockerfiles/debian-sid.docker | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/docker/dockerfiles/debian-sid.docker 
> > b/tests/docker/dockerfiles/debian-sid.docker
> > index 9a3d168705..4e4cda0ba5 100644
> > --- a/tests/docker/dockerfiles/debian-sid.docker
> > +++ b/tests/docker/dockerfiles/debian-sid.docker
> > @@ -13,6 +13,10 @@
> >
> >  FROM debian:sid-slim
> >
> > +# Use a snapshot known to work (see http://snapshot.debian.org/#Usage)
> > +ENV DEBIAN_SNAPSHOT_DATE "20181030"
> > +RUN sed -i "s%^deb \(https\?://\)deb.debian.org/debian/\? \(.*\)%deb 
> > [check-valid-until=no] 
> > \1snapshot.debian.org/archive/debian/${DEBIAN_SNAPSHOT_DATE} \2%" 
> > /etc/apt/sources.list
> > +
> >  # Duplicate deb line as deb-src
> >  RUN cat /etc/apt/sources.list | sed "s/^deb\ /deb-src /" >> 
> > /etc/apt/sources.list
> >
> > --
> > 2.17.2
> >
>
> Queued, thanks!
>
> Fam