[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/10] qdev: move qdev_prop_register_global_l
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 03/10] qdev: move qdev_prop_register_global_list() to tests |
|
Date: |
Wed, 31 Oct 2018 17:22:00 -0300 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Oct 30, 2018 at 07:04:46PM +0400, Marc-André Lureau wrote:
> The function is only used by a test, move it there.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
I would still like to reduce duplication between
machine_register_compat_props() and accel_register_compat_props(),
but that doesn't mean we should keep qdev_prop_register_global_list()
just because we plan to refactor/reuse it some day.
--
Eduardo
- [Qemu-devel] [PATCH v2 00/10] hostmem: use object "id" for memory region name with >= 3.1, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 01/10] qom: make user_creatable_complete() specific to UserCreatable, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 02/10] accel: register global_props like machine globals, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 03/10] qdev: move qdev_prop_register_global_list() to tests, Marc-André Lureau, 2018/10/30
- Re: [Qemu-devel] [PATCH v2 03/10] qdev: move qdev_prop_register_global_list() to tests,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v2 04/10] qom/globals: move qdev globals to qom, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 05/10] qom/globals: generalize object_property_set_globals(), Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 06/10] qom/object: set globals when initializing object, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 09/10] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 07/10] qom/object: add set_globals flags, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 08/10] tests: add user-creatable test to test-qdev-global-props, Marc-André Lureau, 2018/10/30
- [Qemu-devel] [PATCH v2 10/10] hostmem: use object id for memory region name with >= 3.1, Marc-André Lureau, 2018/10/30