[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] monitor: guard iothread access by mon->use_io_th
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 1/8] monitor: guard iothread access by mon->use_io_thread |
Date: |
Tue, 30 Oct 2018 20:16:13 +0100 |
From: Wolfgang Bumiller <address@hidden>
monitor_resume() and monitor_suspend() both want to
"kick" the I/O thread if it is there, but in
monitor_suspend() lacked the use_io_thread flag condition.
This is required when we later only spawn the thread on
first use.
Signed-off-by: Wolfgang Bumiller <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index 823b5a1099..66f149c1dc 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4292,7 +4292,7 @@ int monitor_suspend(Monitor *mon)
atomic_inc(&mon->suspend_cnt);
- if (monitor_is_qmp(mon)) {
+ if (monitor_is_qmp(mon) && mon->use_io_thread) {
/*
* Kick I/O thread to make sure this takes effect. It'll be
* evaluated again in prepare() of the watch object.
--
2.17.2
- [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30, Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 1/8] monitor: guard iothread access by mon->use_io_thread,
Markus Armbruster <=
- [Qemu-devel] [PULL 6/8] tests: add oob functional test for test-qmp-cmds, Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 7/8] tests: qmp-test: add queue full test, Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 8/8] vl: Avoid crash when -mon is underspecified, Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 5/8] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 4/8] monitor: remove "x-oob", turn oob on by default, Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 3/8] monitor: Suspend monitor instead dropping commands, Markus Armbruster, 2018/10/30
- [Qemu-devel] [PULL 2/8] monitor: delay monitor iothread creation, Markus Armbruster, 2018/10/30