[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] target/mips: Enable only tested modes fo
|
From: |
Aleksandar Markovic |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] target/mips: Enable only tested modes for R5900 |
|
Date: |
Tue, 30 Oct 2018 15:28:28 +0000 |
> From: Philippe Mathieu-Daudé <address@hidden>
>
> > +#if defined(CONFIG_USER_ONLY)
>
> > +#if !defined(TARGET_MIPS64)
>
> Can you explain this change in the commit message? I don't understand
why you want to disable this CPU.
These limitations are meant to expose to end-user only features that make sense
and are appropriately tested. People like you can easily comment out theses
lines and do whatever experimentation they like.
About defined(CONFIG_USER_ONLY), it is just because a reasonable testing was
not provided for system mode. It is not enough to add a code, and then enable
system mode. A reasonable ("acceptance") testing should be done, and made
available to others. I know, we do not have strict acceptance rules. But I
would say a system image, kernel, and command line + plus some relatively mild
testing of system mode should suffice. It would be nice to formalize that.
About !defined(TARGET_MIPS64), this is because O32 is the only supported
user-mode ABI for this CPU.
One missing part is documentation update - unfortunately often forgotten.
Aleksandar