qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy contr


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller
Date: Tue, 30 Oct 2018 10:25:15 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 30/10/2018 06:48, Hervé Poussineau wrote:

> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
>> From: Laurent Vivier <address@hidden>
>>
>> Co-developed-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>>   hw/block/Makefile.objs  |   1 +
>>   hw/block/swim.c         | 415 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>   include/hw/block/swim.h |  76 +++++++++
>>   3 files changed, 492 insertions(+)
>>   create mode 100644 hw/block/swim.c
>>   create mode 100644 include/hw/block/swim.h
> 
> [...]
> 
>> diff --git a/include/hw/block/swim.h b/include/hw/block/swim.h
>> new file mode 100644
>> index 0000000000..d6fbdc11ac
>> --- /dev/null
>> +++ b/include/hw/block/swim.h
>> @@ -0,0 +1,76 @@
>> +/*
>> + * QEMU Macintosh floppy disk controller emulator (SWIM)
>> + *
>> + * Copyright (c) 2014-2018 Laurent Vivier <address@hidden>
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2.  See
>> + * the COPYING file in the top-level directory.
>> + *
>> + */
>> +
>> +#ifndef SWIM_H
>> +#define SWIM_H
>> +
>> +#include "qemu/osdep.h"
>> +#include "hw/sysbus.h"
>> +
>> +#define MAX_FD                  2
> 
> Maybe rename MAX_FD to SWIM_MAX_FD, to prevent conflicts with MAX_FD in other 
> files?
> Excepted that:
> Reviewed-by: Hervé Poussineau <address@hidden>

Yes, that's a good idea (I can see this might clash with in-built OS headers). 
I'll
make the change and add your R-B to the next version.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]