qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use


From: maozy
Subject: Re: [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $()instead of ``)
Date: Mon, 22 Oct 2018 21:05:35 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0



On 10/22/18 6:59 PM, Thomas Huth wrote:
On 2018-10-22 09:48, Mao Zhongyi wrote:
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.

Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden

Signed-off-by: Mao Zhongyi <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>

That last line should be "Reviewed-by:" instead - but that can be fixed
when the patch is picked up, no need to resend just because of this nit.

OK, just because I didn't explicitly get R-b. :)

Thanks,
Mao


  Thomas






reply via email to

[Prev in Thread] Current Thread [Next in Thread]