Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900

[Aleksandar Markovic]

> From: Fredrik Noring <address@hidden>
> Subject: [PATCH v8 00/38] target/mips: Limited support for the R5900
> 

Hi, Fredrik.

The series looks good.

I added ASE_MMI flag along with INSN_R5900, I think this fits better in the 
overall MIPS for QEMU design.

I made a couple of other minor changes.

I experienced some build errors (see the end of this mail), so I had to exclude 
some patches, but all others are fine, and had my "Reviewed-by". 32 patches 
will be included in the next MIPS queue.

Thanks for all efforts!

Aleksandar


/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c: In function 
‘gen_mul_txx9’:
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:4888:38: 
error: passing argument 3 of ‘tcg_gen_add2_i32’ from incompatible pointer type 
[-Werror=incompatible-pointer-types]
             tcg_gen_add2_i32(t2, t3, cpu_LO[acc], cpu_HI[acc], t2, t3);
                                      ^~~~~~
In file included from 
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:29:0:
/home/rtrk/Build/qemu-pull-request-oct-22/tcg/tcg-op.h:314:6: note: expected 
‘TCGv_i32 {aka struct TCGv_i32_d *}’ but argument is of type ‘TCGv_i64 {aka 
struct TCGv_i64_d *}’
 void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al,
      ^~~~~~~~~~~~~~~~
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:4888:51: 
error: passing argument 4 of ‘tcg_gen_add2_i32’ from incompatible pointer type 
[-Werror=incompatible-pointer-types]
             tcg_gen_add2_i32(t2, t3, cpu_LO[acc], cpu_HI[acc], t2, t3);
                                                   ^~~~~~
In file included from 
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:29:0:
/home/rtrk/Build/qemu-pull-request-oct-22/tcg/tcg-op.h:314:6: note: expected 
‘TCGv_i32 {aka struct TCGv_i32_d *}’ but argument is of type ‘TCGv_i64 {aka 
struct TCGv_i64_d *}’
 void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al,
      ^~~~~~~~~~~~~~~~
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:4908:38: 
error: passing argument 3 of ‘tcg_gen_add2_i32’ from incompatible pointer type 
[-Werror=incompatible-pointer-types]
             tcg_gen_add2_i32(t2, t3, cpu_LO[acc], cpu_HI[acc], t2, t3);
                                      ^~~~~~
In file included from 
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:29:0:
/home/rtrk/Build/qemu-pull-request-oct-22/tcg/tcg-op.h:314:6: note: expected 
‘TCGv_i32 {aka struct TCGv_i32_d *}’ but argument is of type ‘TCGv_i64 {aka 
struct TCGv_i64_d *}’
 void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al,
      ^~~~~~~~~~~~~~~~
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:4908:51: 
error: passing argument 4 of ‘tcg_gen_add2_i32’ from incompatible pointer type 
[-Werror=incompatible-pointer-types]
             tcg_gen_add2_i32(t2, t3, cpu_LO[acc], cpu_HI[acc], t2, t3);
                                                   ^~~~~~
In file included from 
/home/rtrk/Build/qemu-pull-request-oct-22/target/mips/translate.c:29:0:
/home/rtrk/Build/qemu-pull-request-oct-22/tcg/tcg-op.h:314:6: note: expected 
‘TCGv_i32 {aka struct TCGv_i32_d *}’ but argument is of type ‘TCGv_i64 {aka 
struct TCGv_i64_d *}’
 void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al,
      ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/home/rtrk/Build/qemu-pull-request-oct-22/rules.mak:69: recipe for target 
'target/mips/translate.o' failed
make[1]: *** [target/mips/translate.o] Error 1
Makefile:483: recipe for target 'subdir-mips64-softmmu' failed
make: *** [subdir-mips64-softmmu] Error 2