[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 05/11] nbd: Support auto-read-only option
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v4 05/11] nbd: Support auto-read-only option |
Date: |
Fri, 19 Oct 2018 18:30:09 +0200 |
If read-only=off, but auto-read-only=on is given, open a read-write NBD
connection if the server provides a read-write export, but instead of
erroring out for read-only exports, just degrade to read-only.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/nbd-client.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/nbd-client.c b/block/nbd-client.c
index 9686ecbd5e..76e9ca3abe 100644
--- a/block/nbd-client.c
+++ b/block/nbd-client.c
@@ -992,11 +992,11 @@ int nbd_client_init(BlockDriverState *bs,
logout("Failed to negotiate with the NBD server\n");
return ret;
}
- if (client->info.flags & NBD_FLAG_READ_ONLY &&
- !bdrv_is_read_only(bs)) {
- error_setg(errp,
- "request for write access conflicts with read-only export");
- return -EACCES;
+ if (client->info.flags & NBD_FLAG_READ_ONLY) {
+ ret = bdrv_apply_auto_read_only(bs, "NBD export is read-only", errp);
+ if (ret < 0) {
+ return ret;
+ }
}
if (client->info.flags & NBD_FLAG_SEND_FUA) {
bs->supported_write_flags = BDRV_REQ_FUA;
--
2.19.1
- [Qemu-devel] [PATCH v4 00/11] block: Add auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 01/11] block: Update flags in bdrv_set_read_only(), Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 07/11] curl: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 05/11] nbd: Support auto-read-only option,
Kevin Wolf <=
- [Qemu-devel] [PATCH v4 08/11] gluster: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 06/11] file-posix: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 03/11] rbd: Close image in qemu_rbd_open() error path, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 09/11] iscsi: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 02/11] block: Add auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 04/11] block: Require auto-read-only for existing fallbacks, Kevin Wolf, 2018/10/19
- [Qemu-devel] [PATCH v4 10/11] block: Make auto-read-only=on default for -drive, Kevin Wolf, 2018/10/20
- [Qemu-devel] [PATCH v4 11/11] qemu-iotests: Test auto-read-only with -drive and -blockdev, Kevin Wolf, 2018/10/20