Re: [Qemu-devel] [PATCH 1/9] iotests: Make nbd-fault-injector flush

[Eric Blake]

On 10/19/18 4:48 AM, Max Reitz wrote:
> On 16.10.18 20:07, Eric Blake wrote:
> > On 10/15/18 9:14 AM, Max Reitz wrote:
> > > When closing a connection, make the nbd-fault-injector flush the socket.
> > > Without this, the output is a bit unreliable with Python 3.
> > >
> > > Signed-off-by: Max Reitz <address@hidden>
> > > ---
> > >    tests/qemu-iotests/083.out               | 9 +++++++++
> > >    tests/qemu-iotests/nbd-fault-injector.py | 1 +
> > >    2 files changed, 10 insertions(+)
> >
> > I already had a complaint that the error message in 083.out should NOT
> > be printing a message
>
> You mean the NBD server itself, right?

Yes, the NBD server should not be printing the redundant error messages 
that 083.out exposes.

> >                        (whether the server is python 2 and auto-flushes,
> > or python 3 and needs an explicit flush, the message itself is
> > pointless, and the test is racy as a result).  We may need to revisit
> > this patch when that thread is resolved.
> >
> > https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg01041.html
>
> Well, it's not like the flush hurts either way. :-)

True. On that grounds:

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org