Re: [Qemu-devel] [PATCH 17/20] target/arm: Use gvec for NEON VLD all lanes

[Peter Maydell]

On 11 October 2018 at 21:52, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/translate.c | 81 ++++++++++++++----------------------------
>  1 file changed, 26 insertions(+), 55 deletions(-)

> -                /* VLD2/3/4 to all lanes: bit 5 indicates register stride */
> -                stride = (insn & (1 << 5)) ? 2 : 1;


> +            stride = insn & (1 << 5) ? 2 : 1;

You dropped the clarifying parens in the ?: expression here; I've added
them back...

thanks
-- PMM