[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangl
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list |
Date: |
Fri, 19 Oct 2018 14:00:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 19/10/2018 13:22, Daniel P. Berrangé wrote:
> Copying Paolo, since this probably falls under the "misc patches"
> maintainer bucket.
I think we should define a "generic maintainer stuff" bucket where every
maintainer is supposed to send patches with a Reviewed-by. Maintainers
are probably good enough at getting reviews by an appropriate person.
(I am slowly trying to remove stuff from the misc bucket).
Paolo
> On Thu, Aug 23, 2018 at 11:25:02AM +0100, Daniel P. Berrangé wrote:
>> In some cases the Author: email address in patches submitted to the
>> list gets mangled such that it says
>>
>> John Doe via Qemu-devel <address@hidden>
>>
>> This change is a result of workarounds for DMARC policies.
>>
>> Subsystem maintainers accepting patches need to catch these and fix
>> them before sending pull requests, so a checkpatch.pl test is highly
>> desirable.
>>
>> Signed-off-by: Daniel P. Berrangé <address@hidden>
>> ---
>> scripts/checkpatch.pl | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 42e1c50dd8..be2114a179 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1402,6 +1402,10 @@ sub process {
>> $is_patch = 1;
>> }
>>
>> + if ($line =~ /^Author: .*via Qemu-devel.*<address@hidden>/) {
>> + ERROR("Author email address is mangled by the mailing
>> list\n" . $herecurr);
>> + }
>> +
>> #check the patch for a signoff:
>> if ($line =~ /^\s*signed-off-by:/i) {
>> # This is a signoff, if ugly, so do not double report.
>> --
>> 2.17.1
>>
>
> Regards,
> Daniel
>