[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_c
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc |
Date: |
Fri, 19 Oct 2018 13:49:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-10-19 12:43, Alex Bennée wrote:
> The purpose of the code is to use the designated compiler for building
> the targets test cases. This is not actually host_cc which will still
> be cc even when we are cross compiling. As the tests for $cpu all use
> $cc we should do the same.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Reported-by: Richard Henderson <address@hidden>
> ---
> configure | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/configure b/configure
> index 9138af37f8..d6605bd633 100755
> --- a/configure
> +++ b/configure
> @@ -717,37 +717,37 @@ case "$cpu" in
> ppc|ppc64|s390|s390x|sparc64|x32)
> cpu="$cpu"
> supported_cpu="yes"
> - eval "cross_cc_${cpu}=\$host_cc"
> + eval "cross_cc_${cpu}=\$cc"
> ;;
> i386|i486|i586|i686|i86pc|BePC)
> cpu="i386"
> supported_cpu="yes"
> - cross_cc_i386=$host_cc
> + cross_cc_i386=$cc
> ;;
> x86_64|amd64)
> cpu="x86_64"
> supported_cpu="yes"
> - cross_cc_x86_64=$host_cc
> + cross_cc_x86_64=$cc
> ;;
> armv*b|armv*l|arm)
> cpu="arm"
> supported_cpu="yes"
> - cross_cc_arm=$host_cc
> + cross_cc_arm=$cc
> ;;
> aarch64)
> cpu="aarch64"
> supported_cpu="yes"
> - cross_cc_aarch64=$host_cc
> + cross_cc_aarch64=$cc
> ;;
> mips*)
> cpu="mips"
> supported_cpu="yes"
> - cross_cc_mips=$host_cc
> + cross_cc_mips=$cc
> ;;
> sparc|sun4[cdmuv])
> cpu="sparc"
> supported_cpu="yes"
> - cross_cc_sparc=$host_cc
> + cross_cc_sparc=$cc
> ;;
> *)
> # This will result in either an error or falling back to TCI later
>
Sounds like the right thing to do.
Reviewed-by: Thomas Huth <address@hidden>