Re: [Qemu-devel] [PATCH 2/3] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)

[Alex Bennée]

Mao Zhongyi <address@hidden> writes:

> Various shell files contain a mix between obsolete ``
> and modern $(); It would be nice to convert to using $()
> everywhere.
>
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
>
> Signed-off-by: Mao Zhongyi <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>


> ---
>  tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre 
> b/tests/docker/dockerfiles/debian-bootstrap.pre
> index 3b0ef95374..c164778c30 100755
> --- a/tests/docker/dockerfiles/debian-bootstrap.pre
> +++ b/tests/docker/dockerfiles/debian-bootstrap.pre
> @@ -2,7 +2,7 @@
>  #
>  # Simple wrapper for debootstrap, run in the docker build context
>  #
> -FAKEROOT=`which fakeroot 2> /dev/null`
> +FAKEROOT=$(which fakeroot 2> /dev/null)
>  # debootstrap < 1.0.67 generates empty sources.list, see Debian#732255
>  MIN_DEBOOTSTRAP_VERSION=1.0.67
>
> @@ -52,7 +52,7 @@ fi
>
>  if [ -z $DEBOOTSTRAP_DIR ]; then
>      NEED_DEBOOTSTRAP=false
> -    DEBOOTSTRAP=`which debootstrap 2> /dev/null`
> +    DEBOOTSTRAP=$(which debootstrap 2> /dev/null)
>      if [ -z $DEBOOTSTRAP ]; then
>          echo "No debootstrap installed, attempting to install from SCM"
>          NEED_DEBOOTSTRAP=true


--
Alex Bennée