qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping
Date: Wed, 17 Oct 2018 19:15:46 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Wed, Oct 17, 2018 at 04:59:25PM -0400, Cleber Rosa wrote:
> On 10/17/18 4:46 PM, Murilo Opsfelder Araujo wrote:
[...]
> > Then avocado could multiplex these variants file and call 
> > ./tests/acceptance/run
> > for each value of qemu_bin.  `run` script could skip and return if $qemu_bin
> > doesn't exist.  This approach also allows user forcing a value of qemu_bin 
> > when
> > calling `run` manually, for example:
> > 
> >     ./tests/acceptance/run --qemu_bin=/path/to/your/qemu-system-blah ...
> > 
> > This ./tests/acceptance/run can serve as an entry point to run all the 
> > tests.
> > If more parameters are considered mandatory in the future, the logic can be
> > placed there.
> > 
> 
> I'm completely favorable to having extra scripts or make rules that
> define a standard "job" behavior.  In fact, I think we'll end up having
> many of those.  "make check-acceptance" is just the first one.
> 
> But being able to running individual tests should still be possible, and
> easy IMO.

Agreed.  But is there anything that requires "running an
individual test" to be synonymous to "running a test against only
one QEMU binary"?

We seem to have a terminology problem here: "I'm running one
individual test" may mean something to an user, but mean
something completely different to somebody thinking about Avocado
test cases.  Is this the source of our disagreement?

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]