[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call" |
Date: |
Wed, 17 Oct 2018 13:42:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 17/10/2018 13:38, Pavel Dovgalyuk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>> On 17/10/2018 11:53, Artem Pisarenko wrote:
>>> See my last comment in bug report. This kind of modification, even
>>> adapted to changed function name, doesn't solve issue.
>>> I thought long time that it does, but once I catched qemu with a hang.
>>> And of course, I wasn't able to reproduce it. So it just better hides issue.
>>> Take a look at alternative solution from
>>> QBox:
>>> https://git.greensocs.com/qemu/qbox/commit/a8ed106032e375e715a531d6e93e4d9ec295dbdb
>>> I didn't catched fail with it (yet).
>
> Tried to test it, but rr seems to be broken again.
> I'll try to bisect now.
Can we add a test that runs with "make check" and covers the basics of
record/replay's cpus.c bits?
rr is very cool, and we fixed/understood a lot of stuff when getting it
ready for inclusion. But now it's constantly broken and every time we
change rr we also risk breaking icount.
Paolo
- [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Paolo Bonzini, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Pavel Dovgalyuk, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Artem Pisarenko, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Pavel Dovgalyuk, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Pavel Dovgalyuk, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Artem Pisarenko, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Pavel Dovgalyuk, 2018/10/18
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Paolo Bonzini, 2018/10/17
- Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call", Clement Deschamps, 2018/10/17