[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: Modern shell scripting (us
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: Modern shell scripting (use $() instead of ``) |
Date: |
Wed, 17 Oct 2018 12:05:01 +0200 |
From: Mao Zhongyi <address@hidden>
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
scripts/show-fixed-bugs.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/show-fixed-bugs.sh b/scripts/show-fixed-bugs.sh
index 36f3068..a095a4d 100755
--- a/scripts/show-fixed-bugs.sh
+++ b/scripts/show-fixed-bugs.sh
@@ -23,10 +23,10 @@ while getopts "s:e:cbh" opt; do
done
if [ "x$start" = "x" ]; then
- start=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1`
+ start=$(git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1)
fi
if [ "x$end" = "x" ]; then
- end=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 1`
+ end=$(git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 1)
fi
if [ "x$start" = "x" ] || [ "x$end" = "x" ]; then
@@ -38,9 +38,9 @@ fi
echo "Searching git log for bugs in the range $start..$end"
urlstr='https://bugs.launchpad.net/\(bugs\|qemu/+bug\)/'
-bug_urls=`git log $start..$end \
+bug_urls=$(git log $start..$end \
| sed -n '\,'"$urlstr"', s,\(.*\)\('"$urlstr"'\)\([0-9]*\).*,\2\4,p' \
- | sort -u`
+ | sort -u)
echo Found bug URLs:
for i in $bug_urls ; do echo " $i" ; done
@@ -68,7 +68,7 @@ elif [ "x$show_in_browser" = "x1" ]; then
bugbrowser=xdg-open
elif command -v gnome-open >/dev/null 2>&1; then
bugbrowser=gnome-open
- elif [ "`uname`" = "Darwin" ]; then
+ elif [ "$(uname)" = "Darwin" ]; then
bugbrowser=open
elif command -v sensible-browser >/dev/null 2>&1; then
bugbrowser=sensible-browser
--
1.8.3.1
- [Qemu-devel] [PULL 00/15] qtest and misc patches, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 02/15] target/cris/translate: Get rid of qemu_log_separate(), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 01/15] qemu-common.h: update copyright date to 2018, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 03/15] tests: Prevent more accidental test disabling, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 04/15] tests: remove gcov-files- variables, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 05/15] gdbstub: Remove unused include, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 10/15] mailmap: Fix Reimar Döffinger name, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 08/15] git-submodule.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 15/15] configure: remove glib_subprocess check, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 09/15] show-fixed-bugs.sh: Modern shell scripting (use $() instead of ``),
Thomas Huth <=
- [Qemu-devel] [PULL 14/15] hw/core/generic-loader: Compile only once, not for each target, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 06/15] MAINTAINERS: update block/sheepdog maintainers, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 07/15] archive-source.sh: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 12/15] hw/core/generic-loader: Set a category for the generic-loader device, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 13/15] cpu: Provide a proper prototype for target_words_bigendian() in a header, Thomas Huth, 2018/10/17
- [Qemu-devel] [PULL 11/15] qemu/compiler: Wrap __attribute__((flatten)) in a macro, Thomas Huth, 2018/10/17
- Re: [Qemu-devel] [PULL 00/15] qtest and misc patches, Peter Maydell, 2018/10/18