[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 16/38] xen/pt: Fix incomplete conversion to reali
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v4 16/38] xen/pt: Fix incomplete conversion to realize() |
Date: |
Wed, 17 Oct 2018 10:26:40 +0200 |
The conversion of "xen-pci-passthrough" to realize() (commit
5a11d0f7549, v2.6.0) neglected to convert the xen_pt_config_init()
error path. If xen_pt_config_init() fails, xen_pt_realize() reports
the error, then returns success without completing its job. I don't
know the exact impact, but it can't be good.
Belatedly convert the error path.
Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
Cc: Stefano Stabellini <address@hidden>
Cc: Anthony Perard <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
---
hw/xen/xen_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index e5a6eff44f..f1f3a3727c 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -830,7 +830,7 @@ static void xen_pt_realize(PCIDevice *d, Error **errp)
xen_pt_config_init(s, &err);
if (err) {
error_append_hint(&err, "PCI Config space initialisation failed");
- error_report_err(err);
+ error_propagate(errp, err);
rc = -1;
goto err_out;
}
--
2.17.1
- [Qemu-devel] [PATCH v4 00/38] Replace some unwise uses of error_report() & friends, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 14/38] net/socket: Fix invalid socket type error handling, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 12/38] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 01/38] error: Fix use of error_prepend() with &error_fatal, &error_abort, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 16/38] xen/pt: Fix incomplete conversion to realize(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v4 02/38] Use error_fatal to simplify obvious fatal errors (again), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 08/38] 9pfs: Fix CLI parsing crash on error, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 03/38] block: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 18/38] vl: Clean up error reporting in parse_add_fd(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 11/38] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 20/38] vl: Clean up error reporting in chardev_init_func(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 15/38] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/17