qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report(


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report()
Date: Wed, 17 Oct 2018 07:43:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 10/16/18 12:41 PM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>   block/raw-format.c | 17 +++++++++--------
>>   1 file changed, 9 insertions(+), 8 deletions(-)
>
> Incomplete. tests/qemu-iotests/109.out needs updating:
>
>> @@ -436,14 +437,14 @@ static int raw_open(BlockDriverState *bs, QDict 
>> *options, int flags,
>>               bs->file->bs->supported_zero_flags);
>>         if (bs->probed && !bdrv_is_read_only(bs)) {
>> -        fprintf(stderr,
>> -                "WARNING: Image format was not specified for '%s' and 
>> probing "
>> -                "guessed raw.\n"
>> -                "         Automatically detecting the format is dangerous 
>> for "
>> -                "raw images, write operations on block 0 will be 
>> restricted.\n"
>> -                "         Specify the 'raw' format explicitly to remove the 
>> "
>> -                "restrictions.\n",
>> -                bs->file->bs->filename);
>> +        warn_report("Image format was not specified for '%s' and probing "
>
> as this changes s/WARNING/warning/

Not run by "make check-block"...  Will fix, thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]