[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/38] ioapic: Fix error handling in realize()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 10/38] ioapic: Fix error handling in realize() |
Date: |
Tue, 16 Oct 2018 19:41:30 +0200 |
Calling error_report() in a function that takes an Error ** argument
is suspicious. ioapic_realize() does that, and then exit()s.
Currently mostly harmless, as the device cannot be hot-plugged.
Fixes: 20fd4b7b6d9282fe0cb83601f1821f31bd257458
Cc: Peter Xu <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
hw/intc/ioapic.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index b6896ac4ce..4e529729b4 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -21,7 +21,7 @@
*/
#include "qemu/osdep.h"
-#include "qemu/error-report.h"
+#include "qapi/error.h"
#include "monitor/monitor.h"
#include "hw/hw.h"
#include "hw/i386/pc.h"
@@ -393,9 +393,9 @@ static void ioapic_realize(DeviceState *dev, Error **errp)
IOAPICCommonState *s = IOAPIC_COMMON(dev);
if (s->version != 0x11 && s->version != 0x20) {
- error_report("IOAPIC only supports version 0x11 or 0x20 "
- "(default: 0x%x).", IOAPIC_VER_DEF);
- exit(1);
+ error_setg(errp, "IOAPIC only supports version 0x11 or 0x20 "
+ "(default: 0x%x).", IOAPIC_VER_DEF);
+ return;
}
memory_region_init_io(&s->io_memory, OBJECT(s), &ioapic_io_ops, s,
--
2.17.1
- [Qemu-devel] [PATCH v3 00/38] Replace some unwise uses of error_report() & friends, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 12/38] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 09/38] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 05/38] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 01/38] error: Fix use of error_prepend() with &error_fatal, &error_abort, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 03/38] block: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 18/38] vl: Clean up error reporting in parse_add_fd(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 07/38] char: Use error_printf() to print help and such, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 20/38] vl: Clean up error reporting in chardev_init_func(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 10/38] ioapic: Fix error handling in realize(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 13/38] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 02/38] Use error_fatal to simplify obvious fatal errors (again), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 11/38] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 16/38] xen/pt: Fix incomplete conversion to realize(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 15/38] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 14/38] net/socket: Fix invalid socket type error handling, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 22/38] vl: Clean up error reporting in mon_init_func(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 06/38] vfio: Clean up error reporting after previous commit, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 29/38] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 32/38] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/16