Re: [Qemu-devel] [PATCH 17/28] target/riscv: Convert quadrant 2 of RVXC insns to decodetree

[Richard Henderson]

On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
> address@hidden   ... .  ..... ..... .. &c_flwsp_ldsp uimm_flwsp=%uimm_6bit_lw 
> \
> +    uimm_ldsp=%uimm_6bit_ld %rd
> address@hidden   ... .  ..... ..... .. &c_fswsp_sdsp uimm_fswsp=%uimm_6bit_sw 
> \
> +    uimm_sdsp=%uimm_6bit_sd rs2=%rs2_5

I'm not especially keen about decoding the same bits twice.

I wonder if it's better to call the proper extract_foo function
within the trans_ function like you do elsewhere.  Written as

c_flwsp_ldsp    011 -  ----- ----- 10


r~