Re: [Qemu-devel] [PATCH v5 09/10] linux-user/strace: Improve bind() output

[Laurent Vivier]

On 11/10/2018 00:36, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-By: Guido Günther <address@hidden>
> ---
>  linux-user/strace.c    | 13 +++++++++++++
>  linux-user/strace.list |  2 +-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 14ec5f9f23..9f7480c449 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1966,6 +1966,19 @@ print_socketcall(const struct syscallname *name,
>  }
>  #endif
>  
> +#if defined(TARGET_NR_bind)
> +static void
> +print_bind(const struct syscallname *name,
> +           abi_long arg0, abi_long arg1, abi_long arg2,
> +           abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> +    print_syscall_prologue(name);
> +    print_sockfd(arg0, 0);

print_sockfd() is only defined if TARGET_NR_socketcall is defined, so in
this case it can be undefined.

Thanks,
Laurent