[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest |
Date: |
Fri, 12 Oct 2018 12:42:22 +0200 |
User-agent: |
NeoMutt/20180716 |
Hi,
> > When using qemu_console_get_head() it doesn't work correctly, it would
> > use the qxl card's data. It would work if spice-server would filter the
> > list to only include the entries for the given display channel before
> > calling the ->client_monitors_config() callback. But it doesn't, we get
> > the complete set.
>
> That's why I said is a bug, IMHO it should.
Hmm, this should be easily detectable on qemu side I think. If
num_of_monitors (for a non-qxl card) is > 1, then we have an old,
non-filtering spice-server. If num_of_monitors == 1, then it is a new,
filtering spice-server. Or a single-head channel configuration, in
which case it doesn't matter whenever it filters or not.
So this should be fixable without causing too much compatibility pain.
cheers,
Gerd
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, (continued)
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Frediano Ziglio, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/12
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/12
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Frediano Ziglio, 2018/10/12
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest,
Gerd Hoffmann <=
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Frediano Ziglio, 2018/10/12
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/12