[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch |
Date: |
Thu, 11 Oct 2018 18:31:22 +0100 |
On 10 October 2018 at 20:54, Cleber Rosa <address@hidden> wrote:
> On 10/10/18 2:07 PM, Peter Maydell wrote:
>> We should aim to test the machines we care about (regardless
>> of what architectures they are), rather than thinking about it
>> in terms of "testing architectures X, Y, Z", I think.
>>
>
> To me it's clear that:
>
> 1) I lack a complete understanding of what "we care about"
> 2) It's easier to start with something, and tweak it to taste
Right. Effectively you're already defining a set of
"machines we care about" -- it's just that rather than
explicitly saying 'we care about x86-64 pc, i386 pc, aarch64 virt,
ppc spapr, ...' you're implicitly doing it by defining
a 'default machine' for various architectures and a list
of architectures. I think you should just list the machines
you're testing with, instead.
I don't mind if we start with a list of what we're testing
that's small (or even wrong!) -- we can expand and correct it
later. I'd just like the list to be the correct shape.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, (continued)
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Daniel P . Berrangé, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Peter Maydell, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Peter Maydell, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Eduardo Habkost, 2018/10/10
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/11
- Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch, Eduardo Habkost, 2018/10/11
[Qemu-devel] [PATCH v2 6/7] Acceptance Tests: add variants definition for architectures, Cleber Rosa, 2018/10/09
[Qemu-devel] [PATCH v2 5/7] Acceptance Tests: set machine type, Cleber Rosa, 2018/10/09