[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 3/5] tests: Restore check-qdict unit test
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PULL 3/5] tests: Restore check-qdict unit test |
|
Date: |
Wed, 10 Oct 2018 18:57:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/10/2018 18:43, Eric Blake wrote:
> On 10/10/18 1:11 AM, Markus Armbruster wrote:
>> Commit 0bcc8e5bd8d accidentally dropped check-qdict from the list of
>> unit tests (again, see commit 4429532b48a). Put it back, and fix up
>> the test.
>
> Since this seems to be a recurring problem...
>
>> +++ b/tests/Makefile.include
>> @@ -40,7 +40,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
>> check-unit-y = tests/check-qdict$(EXESUF)
>
> How about a followup patch that does:
>
> - check-unit-y = tests/check-qdict$(EXESUF)
> + check-unit-y =
> + check-unit-y += tests/check-qdict$(EXESUF)
>
Yes, clever :)
- [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2018-10-10, Markus Armbruster, 2018/10/10
- [Qemu-devel] [PULL 5/5] ivshmem: Fix unplug of device "ivshmem-plain", Markus Armbruster, 2018/10/10
- [Qemu-devel] [PULL 3/5] tests: Restore check-qdict unit test, Markus Armbruster, 2018/10/10
- [Qemu-devel] [PULL 4/5] libqtest: Inline g_assert_no_errno(), Markus Armbruster, 2018/10/10
- [Qemu-devel] [PULL 1/5] tests/check-qjson: fix a leak, Markus Armbruster, 2018/10/10
- [Qemu-devel] [PULL 2/5] qapi/misc.json: Remove superfluous words in CpuModelExpansionType, Markus Armbruster, 2018/10/10
- Re: [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2018-10-10, Peter Maydell, 2018/10/11