Re: [Qemu-devel] [Qemu-arm] [RFC PATCH] hw: arm: Add basic support for cprman (clock subsystem)

[Guenter Roeck]

On Wed, Oct 10, 2018 at 03:25:22PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Guenter,
> 
> On Tue, Jul 17, 2018 at 6:08 AM Guenter Roeck <address@hidden> wrote:
> >
> > On 07/16/2018 06:53 PM, Philippe Mathieu-Daudé wrote:
> > > Hi Guenter,
> > >
> > > On 07/15/2018 07:06 PM, Guenter Roeck wrote:
> > >> Add basic support for BCM283x CPRMAN. Provide support for reading and
> > >> writing CPRMAN registers and initialize registers with sensible default
> > >> values. During runtime retain any written values.
> > >>
> > >> Basic CPRMAN support is necessary and sufficient to boot Linux on raspi2
> > >> and raspi3 systems.
> > >>
> > >> Signed-off-by: Guenter Roeck <address@hidden>
> > >> ---
> > >> I don't seriously expect this patch to get accepted, but I thought
> > >> it might be valuable enough for others to use it when playing with
> > >> raspi2 and raspi3 emulations.
> > >
> > > I've been working on a very similar patch... But due to soft-freeze I
> > > postponed it.
> > >
> >
> > > I don't feel very confident with my local work, as you, it is based on
> > > looking at the Broadcom firmware [1] and how the Linux kernel initialize
> > > the devices. I'll however compare with your work.
> > >
> >
> > I'll be more than happy to drop my patch and go with yours instead.
> > Let's just do that - it looks like it is much more comprehensive.
> 
> Did you make any progress with your work?
> 
My patch works for me, and continue using it. My suggestion above was
for you to finalize your patch and submit it. I did not spend any further
time on it. Sorry for any confusion I may have caused.

> Your patch might be useful to solve the following issue:
> https://bugs.launchpad.net/bugs/1779017

Yes, that was one of the reasons for writing the patch in the first place.

Thanks,
Guenter