[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest |
Date: |
Wed, 10 Oct 2018 12:37:04 +0200 |
User-agent: |
NeoMutt/20180716 |
Hi,
> > + * Sets the hardware (e.g. PCI) path of the graphics device
> > represented by this QXL interface instance.
>
> So, this comment suggests that the caller might be able to provide a
> path that is not a PCI path. But the implementation below (mostly the
> debug output, I suppose...) assumes a PCI path. Do we need to support
> non-PCI paths?
Certainly not for the initial revision, maybe never.
But thanks to the "pci/" prefix we should be able to add support for
other paths later in case it turns out we need it.
> > + * Returns: The actual SPICE server monitor_id associated with the
> > display
>
> So, if I remember correctly, Gerd recommended returning this value from
> the function. But I think it needs more explanation here. What exactly
> is a "monitor_id" supposed to represent? It is not used in your follow-
> up qemu patch so it's hard to tell.
IIRC the plan was to ditch the global monior_id idea and use the
(channel_id, display_id) tuple everywhere ...
cheers,
Gerd
- [Qemu-devel] [RFC PATCH spice/qemu 0/2] QXL interface to set monitor ID, Lukáš Hrázký, 2018/10/09
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/10
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Frediano Ziglio, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Gerd Hoffmann, 2018/10/11
- Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest, Lukáš Hrázký, 2018/10/11