qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/31] vfio: Clean up error reporting after prev


From: Alex Williamson
Subject: Re: [Qemu-devel] [PATCH 05/31] vfio: Clean up error reporting after previous commit
Date: Mon, 8 Oct 2018 13:04:24 -0600

On Mon,  8 Oct 2018 19:30:59 +0200
Markus Armbruster <address@hidden> wrote:

> The previous commit changed vfio's warning messages from
> 
>     vfio warning: DEV-NAME: Could not frobnicate
> 
> to
> 
>     warning: vfio DEV-NAME: Could not frobnicate
> 
> To match this change, change error messages from
> 
>     vfio error: DEV-NAME: On fire
> 
> to
> 
>     vfio DEV-NAME: On fire
> 
> Note the loss of "error".  If we think marking error messages that way
> is a good idea, we should mark *all* error messages, i.e. make
> error_report() print it.
> 
> Cc: Alex Williamson <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/vfio/pci-quirks.c          | 4 ++--
>  hw/vfio/pci.c                 | 8 ++++----
>  hw/vfio/platform.c            | 2 +-
>  include/hw/vfio/vfio-common.h | 1 -
>  4 files changed, 7 insertions(+), 8 deletions(-)

Acked-by: Alex Williamson <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]