Re: [Qemu-devel] [PULL 00/15] s390x updates

[Alex Bennée]

Peter Maydell <address@hidden> writes:

> On 4 October 2018 at 16:28, Cornelia Huck <address@hidden> wrote:
>> The following changes since commit dafd95053611aa14dda40266857608d12ddce658:
>>
>>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
>> staging (2018-10-02 18:27:18 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/cohuck/qemu tags/s390x-20181004
>>
>> for you to fetch changes up to b576d582ea2b03f4eada186fff59308d22b40a6a:
>>
>>   hw/s390x/s390-pci-bus: Convert sysbus init function to realize function 
>> (2018-10-04 12:10:40 +0200)
>>
>> ----------------------------------------------------------------
>> Various s390x updates:
>> - fix several struct definitions so that sparc hosts do not trip over
>>   unaligned accesses
>> - fence enabling huge pages for pre-3.1 machines
>> - sysbus init -> realize conversion
>> - fixes and improvements in tcg (instruction flags and AFP registers)
>
> Applied, thanks.
<snip>

This pull has broken s390x-linux-user tcg tests:

  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/multiarch/Makefile.target:30: recipe 
for target 'run-test-mmap' failed
  make[2]: *** [run-test-mmap] Error 132
  make[2]: *** Waiting for unfinished jobs....
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-linux-test' failed
  make[2]: *** [run-linux-test] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-hello-s390x' failed
  make[2]: *** [run-hello-s390x] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-ipm' failed
  make[2]: *** [run-ipm] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-exrl-trtr' failed
  make[2]: *** [run-exrl-trtr] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-testthread' failed
  make[2]: *** [run-testthread] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-exrl-trt' failed
  make[2]: *** [run-exrl-trt] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-sha1' failed
  make[2]: *** [run-sha1] Error 132
  timeout: the monitored command dumped core
  Illegal instruction
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile:96: recipe for target 
'run-csst' failed
  make[2]: *** [run-csst] Error 132
  /home/alex/lsrc/qemu/qemu.git/tests/tcg/Makefile.include:71: recipe for 
target 'run-guest-tests' failed
  make[1]: *** [run-guest-tests] Error 2
  /home/alex/lsrc/qemu/qemu.git/tests/Makefile.include:968: recipe for target 
'run-tcg-tests-s390x-linux-user' failed
  make: *** [run-tcg-tests-s390x-linux-user] Error 2

which are now showing up on Travis (admitidly hidden by the usual Travis
noise). I have bisected the breakage:

  git bisect start
  git bisect bad b576d582ea2b03f4eada186fff59308d22b40a6a
  b576d582ea bad hw/s390x/s390-pci-bus: Convert sysbus init function to realize 
function
  git bisect good dafd95053611aa14dda40266857608d12ddce658
  dafd950536 good Merge remote-tracking branch 
'remotes/bonzini/tags/for-upstream' into staging
  git bisect good bbf6ea3bd961970785a583117ac1c0b84a8ee736
  bbf6ea3bd9 good s390x/tcg: factor out and fix DATA exception injection
  git bisect bad db0504154ef1feedd135f25f8ca6e9abb5d00bbb
  db0504154e bad s390x/tcg: check for AFP-register, BFP and DFP data exceptions
  git bisect good 82d179336dd696d04495963ca007fa961496d924
  82d179336d good s390x/tcg: support flags for instructions
  git bisect good ca5f31a0f27d265f2220ad43913f70280e8753a2
  ca5f31a0f2 good s390x/tcg: add instruction flags for floating point 
instructions

Which is points at:

  Bisect Rest (1)
  db0504154e * bad @ s390x/tcg: check for AFP-register, BFP and DFP data 
exceptions

--
Alex Bennée