[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype
From: |
Pankaj Gupta |
Subject: |
Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype |
Date: |
Sun, 7 Oct 2018 23:50:46 -0400 (EDT) |
Hello David,
Thanks for the review.
> >
> > > On 24/09/2018 07:45, David Gibson wrote:
> > > > On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote:
> > > >> From: Pankaj Gupta <address@hidden>
> > > >>
> > > >> This is the current protoype of virtio-pmem. Support will require
> > > >> machine changes for the architectures that will support it, so it will
> > > >> not yet be compiled.
> > > >>
> > > >> Signed-off-by: Pankaj Gupta <address@hidden>
> > > >> [ MemoryDevice/MemoryRegion changes, cleanups, addr property
> > > >> "memaddr",
> > > >> split up patches ]
> > > >> Signed-off-by: David Hildenbrand <address@hidden>
> > > >
> > > > Reviewed-by: David Gibson <address@hidden>
> > > >
> > > > Seems generally sane. Is there a (craft?) virtio-pmem spec around to
> > > > see what this is actually trying to implement?
> > >
> > > I am not aware of any. The first goal is to get something implemented
> > > that works and doesn't break important concepts. E.g. hotplugging memory
> > > devices was one of these concepts that Igor saw as a potential problem
> > > for getting virtio-pmem upstream.
> > >
> > > But maybe Pankaj already has some draft version of a spec lying around.
> >
> > I have created document but no official spec. Project idea is shared here
> > [1]
> > and kernel part of series [2]. I will create a spec and share.
> >
> > [1] https://www.spinics.net/lists/kvm/msg153095.html
> > [2] https://marc.info/?l=kvm&m=153572224719212&w=2
>
> Ok. Because this creates a new interface we could be working with for
> a while, I think we do need at least a semi-formal spec - and to get
> some review of that spec - before we merge.
Sure, Will create one and try to send for review this week.
Thanks,
Pankaj
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
>