[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 05/21] trace: keep a count of trace-point hi
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 05/21] trace: keep a count of trace-point hits |
|
Date: |
Sat, 6 Oct 2018 11:26:28 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/5/18 8:48 AM, Alex Bennée wrote:
> @@ -81,6 +81,8 @@ def generate_c(event, group):
> cond = "trace_event_get_state(%s)" % event_id
>
> out('',
> + ' %(event_obj)s.count++;',
> + '',
> ' if (!%(cond)s) {',
> ' return;',
> ' }',
Is it really "hit" if the condition isn't true? And you'd want to document the
non-atomicity in a comment, lest it be "fixed" later.
r~
- Re: [Qemu-devel] [RFC PATCH 08/21] accel/tcg/cputlb: convert remaining tlb_debug() to trace events, (continued)
[Qemu-devel] [RFC PATCH 04/21] trace: enable the exec_tb trace events, Alex Bennée, 2018/10/05
[Qemu-devel] [RFC PATCH 01/21] util/log: allow -dfilter to stack, Alex Bennée, 2018/10/05
[Qemu-devel] [RFC PATCH 05/21] trace: keep a count of trace-point hits, Alex Bennée, 2018/10/05
- Re: [Qemu-devel] [RFC PATCH 05/21] trace: keep a count of trace-point hits,
Richard Henderson <=
[Qemu-devel] [RFC PATCH 18/21] linux-user: allow dumping of plugin status at end of run, Alex Bennée, 2018/10/05
[Qemu-devel] [RFC PATCH 10/21] qom/cpu: add a cpu_exit trace event, Alex Bennée, 2018/10/05
[Qemu-devel] [RFC PATCH 12/21] configure: expose a plugin to the trace-backends, Alex Bennée, 2018/10/05
[Qemu-devel] [RFC PATCH 13/21] tracetool: generate plugin snippets, Alex Bennée, 2018/10/05
[Qemu-devel] [RFC PATCH 09/21] trace: suppress log output of trace points, Alex Bennée, 2018/10/05