Re: [Qemu-devel] [PULL v3 00/79] Misc patches for 2018-09-30

[Peter Maydell]

On 1 October 2018 at 16:29, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit 042938f46e1c477419d1931381fdadffaa49d45e:
>
>   Merge remote-tracking branch 
> 'remotes/dgilbert/tags/pull-migration-20180926a' into staging (2018-09-28 
> 17:07:23 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 72d09800e7b85fa1a14b88d341ca8c042d236cba:
>
>   hw/scsi/mptendian: Avoid taking address of fields in packed structs 
> (2018-10-01 17:28:02 +0200)
>
> ----------------------------------------------------------------
> * configure fix for environment variables (Daniel)
> * fix memory leaks (Alex)
> * x86_64 MTTCG fixes (Emilio)
> * introduce atomic64 (Emilio)
> * Fix for virtio hang (Fam, myself)
> * SH serial port fix (Geert)
> * Deprecate rotation_rate for scsi-block (Fam)
> * Extend memory-backend-file availability to all POSIX hosts (Hikaru)
> * Memory API cleanups and fixes (Igor, Li Qiang, Peter, Philippe)
> * MSI/IOMMU fix (Jan)
> * Socket reconnection fixes (Marc-André)
> * icount fixes (Emilio, myself)
> * QSP fixes for Coverity (myself)
> * Some record/replay improovements (Pavel)
> * Packed struct fixes (Peter)
> * Windows dump fixes and elf2dmp (Viktor)
> * kvmclock fix (Yongji)
>
> ----------------------------------------------------------------

Hi; compile failures due to format string issues, I'm afraid:

/home/petmay01/qemu-for-merges/hw/mips/mips_r4k.c: In function 'load_kernel':
/home/petmay01/qemu-for-merges/hw/mips/mips_r4k.c:139:47: error:
format '%li' expects argument of type 'long int', but argument 5 has
type 'int64_t {aka long long int}' [-Werror=format=]
         snprintf((char *)params_buf + 8, 256, "rd_start=0x%" PRIx64 "
rd_size=%li %s",
                                               ^
cc1: all warnings being treated as errors

/home/petmay01/qemu-for-merges/hw/mips/mips_malta.c: In function 'load_kernel':
/home/petmay01/qemu-for-merges/hw/mips/mips_malta.c:1073:42: error:
format '%li' expects argument of type 'long int', but argument 5 has
type 'int64_t {aka long long int}' [-Werror=format=]
         prom_set(prom_buf, prom_index++, "rd_start=0x%" PRIx64 "
rd_size=%li %s",
                                          ^

I also saw this in the freebsd VM test:

MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
gtester -k --verbose -m=quick tests/test-char
TEST: tests/test-char... (pid=15938)
  /char/null:                                                          OK
  /char/invalid:                                                       OK
  /char/ringbuf:                                                       OK
  /char/mux:                                                           OK
  /char/stdio:                                                         OK
  /char/pipe:                                                          OK
  /char/file:                                                          OK
  /char/file-fifo:                                                     OK
  /char/udp:                                                           OK
  /char/serial:                                                        OK
  /char/hotswap:                                                       OK
  /char/socket/basic:                                                  OK
  /char/socket/reconnect:                                              FAIL
GTester: last random seed: R02S615917be6302ea7de5d0fc9c58149953
(pid=16010)
  /char/socket/fdpass:                                                 OK
FAIL: tests/test-char
**
ERROR:tests/test-char.c:353:char_socket_test_common: assertion failed:
(object_property_get_bool(OBJECT(chr_client), "connected",
&error_abort))
gmake: *** [/var/tmp/qemu-test.YRve5C/tests/Makefile.include:925:
check-tests/test-char] Error 1


Haven't seen that before, so maybe it's something in this patchset;
it could be a pre-existing intermittent though I suppose.

thanks
-- PMM