[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/15] gdbstub: add support for extended mode
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/15] gdbstub: add support for extended mode packet |
Date: |
Mon, 1 Oct 2018 18:39:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Hi Luc,
On 01/10/2018 13:56, Luc Michel wrote:
> Add support for the '!' extended mode packet. This is required for the
> multiprocess extension.
>
> Signed-off-by: Luc Michel <address@hidden>
> ---
> gdbstub.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 299783b3b8..d372972dd3 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1280,10 +1280,13 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> trace_gdbstub_io_command(line_buf);
>
> p = line_buf;
> ch = *p++;
> switch(ch) {
> + case '!':
> + put_packet(s, "OK");
Don't we want to also support the 'R' packet?
> + break;
> case '?':
> /* TODO: Make this return the correct value for user-mode. */
> snprintf(buf, sizeof(buf), "T%02xthread:%s;", GDB_SIGNAL_TRAP,
> gdb_fmt_thread_id(s, s->c_cpu, thread_id,
> sizeof(thread_id)));
> put_packet(s, buf);
>
- [Qemu-devel] [PATCH v2 00/15] gdbstub: support for the multiprocess extension, Luc Michel, 2018/10/01
- [Qemu-devel] [PATCH v2 10/15] gdbstub: add support for extended mode packet, Luc Michel, 2018/10/01
- Re: [Qemu-devel] [PATCH v2 10/15] gdbstub: add support for extended mode packet,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 03/15] gdbstub: add multiprocess support to 'H' and 'T' packets, Luc Michel, 2018/10/01
- [Qemu-devel] [PATCH v2 04/15] gdbstub: add multiprocess support to vCont packets, Luc Michel, 2018/10/01
- [Qemu-devel] [PATCH v2 05/15] gdbstub: add multiprocess support to 'sC' packets, Luc Michel, 2018/10/01
- [Qemu-devel] [PATCH v2 09/15] gdbstub: add multiprocess support to 'D' packets, Luc Michel, 2018/10/01
- [Qemu-devel] [PATCH v2 06/15] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo, Luc Michel, 2018/10/01