[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/test-bdrv-drain: Fix too late qemu_event_
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests/test-bdrv-drain: Fix too late qemu_event_reset() |
|
Date: |
Mon, 1 Oct 2018 18:13:10 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 01.10.18 17:10, Kevin Wolf wrote:
> qemu_event_reset() must be called before the AIO request in a different
> iothread is submitted. Otherwise the request could be completed before
> we do the qemu_event_reset() and the test would hang in
> qemu_event_wait().
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/test-bdrv-drain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
Tested-by: Max Reitz <address@hidden>
(I still got the same hang as the one you just reported, though -- but
it happens just very rarely, so it's definitely better.)
signature.asc
Description: OpenPGP digital signature