Re: [Qemu-devel] [PATCH 0/2] RFC: object: recommend a few type check macros

[Marc-André Lureau]

Hi

On Mon, Sep 24, 2018 at 1:30 PM Igor Mammedov <address@hidden> wrote:
>
> On Fri, 21 Sep 2018 15:13:30 +0400
> Marc-André Lureau <address@hidden> wrote:
>
> > Hi,
> >
> > This is a readability suggestion. See the first patch for the doc
> > change, and the second patch for an example of usage and readability
> > improvement.
> Looks like a nice improvement,
> but could you conversion tree wide so we end up with a consistent
> way to cast across the tree.
> Probably it would result in negative diffstat and demonstrate
> usefulness of the simplification in numbers.

It doesn't result in negative diffstat, since often a one-liner is
replaced by a 2-liner macro ;)

However, the resulting code is more pleasant to read imho.

I attached the whole diff here, the branch with the 49 patches
split-series is here: https://github.com/elmarco/qemu/commits/object

Let me know what you think

>
> > thanks
> >
> > Marc-André Lureau (2):
> >   object: recommend a few type check macros
> >   nvdimm: use IS_NVDIMM macro
> >
> >  include/hw/mem/nvdimm.h |  1 +
> >  include/qom/object.h    | 25 ++++++++++++++++---------
> >  hw/acpi/ich9.c          |  2 +-
> >  hw/acpi/nvdimm.c        |  2 +-
> >  hw/acpi/piix4.c         |  2 +-
> >  hw/i386/pc.c            |  8 +++-----
> >  hw/mem/pc-dimm.c        |  2 +-
> >  7 files changed, 24 insertions(+), 18 deletions(-)
> >
>
>


--
Marc-André Lureau

diff.patch
Description: Source code patch