Re: [Qemu-devel] [PATCH v4 6/9] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

[Peter Xu]

On Thu, Sep 27, 2018 at 04:45:59PM +0000, Singh, Brijesh wrote:

[...]

> +    /* validate that we are configure with intremap=on */
> +    if (!X86_IOMMU_DEVICE(iommu)->intr_supported) {
> +        error_report("Interrupt remapping is enabled in the guest but "
> +                     "not in the host. Use intremap=on to enable interrupt "
> +                     "remapping in amd-iommu.");

Same here: please use error_report_once() or tracepoints.  Otherwise
it looks good to me.

Let's just make sure no error_report() is used.

> +        return -AMDVI_IR_ERR;
> +    }

[...]

Regards,

-- 
Peter Xu