[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] multiboot: Make the message more user friendly
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] multiboot: Make the message more user friendly |
|
Date: |
Thu, 27 Sep 2018 15:37:02 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/26/18 2:29 AM, Mao Zhongyi wrote:
Since this one is intended to be a user-facing error message
rather than just a debug note, it could also be reasonably
expanded to be a bit more user friendly.
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Mao Zhongyi <address@hidden>
---
hw/i386/multiboot.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 1a4344f..44fc7d8 100644
--- a/hw/i386/multiboot.c
+++ b/hw/i386/multiboot.c
@@ -186,7 +186,8 @@ int load_multiboot(FWCfgState *fw_cfg,
memset(&mbs, 0, sizeof(mbs));
if (flags & 0x00000004) { /* MULTIBOOT_HEADER_HAS_VBE */
- error_report("multiboot knows VBE. we don't");
+ error_report("This multiboot image uses VBE, which QEMU "
+ "does not support");
Definite improvement in the grammar over the original.
}
if (!(flags & 0x00010000)) { /* MULTIBOOT_HEADER_HAS_ADDR */
uint64_t elf_entry;
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org