Re: [Qemu-devel] [PATCH v9 1/6] linux-headers: linux header updates for AP support

[Cornelia Huck]

On Thu, 27 Sep 2018 09:41:31 +0200
David Hildenbrand <address@hidden> wrote:

> On 27/09/2018 00:54, Tony Krowiak wrote:
> > Updates the linux header files in preparation for introduction
> > of the VFIO AP device:
> > 
> > * Added a feature ID to indicate AP facilities are installed
> > 
> > * Added device attributes to the KVM_S390_VM_CRYPTO group
> >   to indicate whether AP instructions are to be interpreted
> > 
> > * Added VFIO device information for AP devices
> > 
> > Signed-off-by: Tony Krowiak <address@hidden>
> > ---
> >  linux-headers/asm-s390/kvm.h | 3 +++
> >  linux-headers/linux/vfio.h   | 2 ++
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h
> > index 1ab9901911bf..b4948706468e 100644
> > --- a/linux-headers/asm-s390/kvm.h
> > +++ b/linux-headers/asm-s390/kvm.h
> > @@ -130,6 +130,7 @@ struct kvm_s390_vm_cpu_machine {
> >  #define KVM_S390_VM_CPU_FEAT_PFMFI 11
> >  #define KVM_S390_VM_CPU_FEAT_SIGPIF        12
> >  #define KVM_S390_VM_CPU_FEAT_KSS   13
> > +#define KVM_S390_VM_CPU_FEAT_AP            14  
> 
> Guess that's a leftover. But should be fixed automatically by proper
> header sync later.

Yep.

Generally, I don't look at "header updates" patches after the interface
has been hashed out already, as they'll be replaced by a formal header
sync anyway.